Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new page for awesome-webpack #5275

Merged
merged 7 commits into from
Aug 10, 2021
Merged

Add new page for awesome-webpack #5275

merged 7 commits into from
Aug 10, 2021

Conversation

snitin315
Copy link
Member

@vercel
Copy link

vercel bot commented Aug 6, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/2JZ7pwPnpsXAYj5rmaGk9tq18ggh
✅ Preview: https://webpack-js-org-git-awesome-webpack-webpack-docs.vercel.app

alexander-akait
alexander-akait previously approved these changes Aug 6, 2021
View reviewed changes
chenxsan
chenxsan reviewed Aug 7, 2021
View reviewed changes
Copy link
Member

@chenxsan chenxsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many links targeting older version webpack - I've just marked some of them that are obvious, since we're adding this page for webpack 5, it would be great to remove them all in my opinion.

src/content/awesome-webpack.md Outdated Show resolved Hide resolved
src/content/awesome-webpack.md Outdated Show resolved Hide resolved
src/content/awesome-webpack.md Outdated Show resolved Hide resolved
src/content/awesome-webpack.md Outdated Show resolved Hide resolved
src/content/awesome-webpack.md Outdated Show resolved Hide resolved
src/content/awesome-webpack.md Outdated Show resolved Hide resolved
src/content/awesome-webpack.md Outdated Show resolved Hide resolved
src/content/awesome-webpack.md Outdated Show resolved Hide resolved
alexander-akait
alexander-akait previously approved these changes Aug 9, 2021
View reviewed changes
@alexander-akait
Copy link
Member

/cc @chenxsan can you review?

@chenxsan chenxsan mentioned this pull request Aug 10, 2021
Merged
@chenxsan chenxsan mentioned this pull request Aug 10, 2021
Merged
chenxsan
chenxsan reviewed Aug 10, 2021
View reviewed changes
Copy link
Member

@chenxsan chenxsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some broken links needs updated or removed, then we are good to merge.

src/content/awesome-webpack.md Outdated Show resolved Hide resolved
src/content/awesome-webpack.md Outdated Show resolved Hide resolved
src/content/awesome-webpack.md Outdated Show resolved Hide resolved
src/content/awesome-webpack.md Outdated Show resolved Hide resolved
src/content/awesome-webpack.md Outdated Show resolved Hide resolved
@snitin315 snitin315 requested a review from chenxsan August 10, 2021 12:36
@snitin315 snitin315 mentioned this pull request Aug 10, 2021
Merged
@chenxsan chenxsan merged commit c038c71 into master Aug 10, 2021
@chenxsan chenxsan deleted the awesome-webpack branch August 10, 2021 13:01
@anshumanv anshumanv mentioned this pull request Aug 10, 2021
Closed
@chenxsan chenxsan mentioned this pull request Aug 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenxsan chenxsan chenxsan approved these changes

@alexander-akait alexander-akait alexander-akait left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

union with webpack docs site
3 participants
@snitin315 @alexander-akait @chenxsan